Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redact numeric sequences and uuids from plausible analytics #5240

Merged
merged 16 commits into from
Apr 5, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Apr 5, 2023

Proposed Changes:

  • Use script.manual.js instead of script.js to support custom functionalities.
  • Redact numeric sequences and uuid's from page url with ID_REDACTED
  • Remove empty query params if any
  • Remove 'page' and 'limit' query params by blacklisting it

References:

rithviknishad and others added 13 commits April 5, 2023 09:21
Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
* added icon

* added phone icon

---------

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
* Update experience commenced labels to "Years of experience".

* Switch doctor_experience_commenced_on to number input

* disallow negative years of exp.

* Switch YoE on UserProfile

---------

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
* revamped button

* refactor

* added buttons

* added icons

* increase icon size
* fixes #5226

* adds location name beside bed number

* ask location at beginning by a popup
…` with locale support (#5203)

* Adds reusable component: `SortDropdownMenu`

* update patient sort menu

* adds badge type: Ordering, add locale support

* Scope sort options locales to prevent conflicts

* suffix " first" in every sort option labels

* minor locale fix

* minor fix in extracting locale string

* minor locale fix

* highlight current sort by

---------

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
* fix(consultation): added pain scale diagram

* fix(consultation): added pain scale heading & summary

---------

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
* fix(patient): added respiratory support icons and badges for the patient

* fix(consultation): added icon for respiratory support

* fix(patient): fixed icon badge in patient list & consultation details

* Update src/Components/Patient/PatientInfoCard.tsx

---------

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
* Adds `FiltersSlideover`

* Upgrade `FacilityFilter` to use `FiltersSlideover`

* rename: `PatientFilterV2` -> `PatientFilter`

* minor fix in `FiltersSlideover`

* Upgrade `PatientFilter` to use `FiltersSlideover`

* minor fix in `FiltersSlideover`

* Upgrade `AssetFilter` to use `FiltersSlideover`

* Upgrade `SampleFilters` to use `FiltersSlideover`

* Upgrade External Result filter to use `FiltersSlideover`

* Upgrade `UserFilter` to use `FiltersSlideover`

* Upgrade Resource and Shifting Filters

* Remove no longer used `FilterButtons` component

* minor ui fix

* translations

* fix `FiltersSlideover` max-w

* generalize Advanced Filters buton

* fix filters not clearing

* fix asset location state management

---------

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
* Remove caching logic from serviceworker

* fix compilation

* Fix compilation
@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 0:48am

@netlify
Copy link

netlify bot commented Apr 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a4debf7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642d635ab02e960008e2ff06
😎 Deploy Preview https://deploy-preview-5240--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 5, 2023

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/642d4dfbb993e40e30dabfd3

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview cypress failed pull request with cypress test failure labels Apr 5, 2023
@nihal467 nihal467 removed the Deploy-Failed Deplyment is not showing preview label Apr 5, 2023
@rithviknishad rithviknishad changed the base branch from develop to plausible-from-use-config April 5, 2023 12:46
@rithviknishad rithviknishad marked this pull request as ready for review April 5, 2023 12:47
@rithviknishad rithviknishad requested a review from a team April 5, 2023 12:47
@rithviknishad rithviknishad requested a review from a team as a code owner April 5, 2023 12:47
@rithviknishad rithviknishad requested review from bodhish and removed request for a team April 5, 2023 12:47
@rithviknishad rithviknishad merged commit ef8a8cb into plausible-from-use-config Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.6% 5.6% Duplication

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

khavinshankar pushed a commit that referenced this pull request Apr 7, 2023
…ead of env, redact IDs in URLs (#5229)

* fixes #5228

* Adds a `Script` component

* include Plausible script in App

* remove script from index.html

* redact numeric sequences and uuids from plausible analytics (#5240)

* this should work now :)

* updated script component that fixes issue in firefox

* remove empty query params and redacts if non-empty

* fix special char issues and redact uuids before numeric ids

* fix empty qparams not being removed and blacklist some qparams
@rithviknishad rithviknishad deleted the plausible/redact-ids branch July 26, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants