Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in label-wip.yml workflow file #5249

Closed
wants to merge 1 commit into from

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Apr 6, 2023

Fixed a syntax error in the label-wip.yml workflow file, which was preventing the workflow from running correctly. The error was in the if condition of the label-issues job, where the expression used to check whether the linked_issues output of the check-linked-issues job was not empty was incorrect. The length function was used instead to correctly check the length of the linked_issues string.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team April 6, 2023 06:03
@Ashesh3 Ashesh3 requested a review from a team as a code owner April 6, 2023 06:03
@Ashesh3 Ashesh3 requested a review from vigneshhari April 6, 2023 06:03
@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 6:04am

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 99be158
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642e609e7c57b20008d9b0b3
😎 Deploy Preview https://deploy-preview-5249--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rithviknishad
Copy link
Member

rithviknishad commented Apr 6, 2023

@Ashesh3 possible duplicate of #5204.
Does your pr solve anything additionally?

@Ashesh3 Ashesh3 closed this Apr 6, 2023
@Ashesh3
Copy link
Member Author

Ashesh3 commented Apr 6, 2023

@Ashesh3 possible duplicate of #5204. Does your pr solve anything additionally?

Nothing additionally!

@Ashesh3
Copy link
Member Author

Ashesh3 commented Apr 6, 2023

@rithviknishad Side note, any clue on cypress timing out waiting for care_fe to start? https://github.com/coronasafe/care_fe/actions/runs/4625566014/jobs/8181444664#step:10:31

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 6, 2023
@rithviknishad
Copy link
Member

rithviknishad commented Apr 6, 2023

@Ashesh3 no idea at present. I'm a bit occupied till tomorrow to try to replicate this locally.

@sainak sainak deleted the wip-workflow-fix branch January 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants