Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark patient as expired only after discharge in shifting #5404

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Apr 25, 2023

WHAT

🤖 Generated by Copilot at da7b2d6

Refactor the shifting details update component to improve the discharge confirmation logic for expired patients. Fix the type definition of the handleChange function in ShiftDetailsUpdate.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at da7b2d6

  • Import FieldChangeEvent type to use in handleChange function (link)
  • Modify handleSubmit function to accept discharged parameter and show DischargeModal if patient is not discharged and status is "PATIENT EXPIRED" (link, link)
  • Change afterSubmit callback of DischargeModal to call handleSubmit with discharged set to true (link)
  • Change onClick handler of Submit to call handleSubmit without arguments (link)

@khavinshankar khavinshankar added urgent needs testing P1 breaking issue or vital feature labels Apr 25, 2023
@khavinshankar khavinshankar requested a review from a team April 25, 2023 07:58
@khavinshankar khavinshankar requested a review from a team as a code owner April 25, 2023 07:58
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 2:23pm

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0254bf9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/644933778871190008a64f83
😎 Deploy Preview https://deploy-preview-5404--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 25, 2023
@nihal467
Copy link
Member

LGTM

@gigincg gigincg merged commit c4de2b5 into develop Apr 26, 2023
5 of 7 checks passed
@github-actions
Copy link

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sainak sainak deleted the fix#5388 branch January 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shifting- Patient expired
3 participants