Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added admit patient button in completed shifting cards #5405

Closed
wants to merge 1 commit into from

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Apr 25, 2023

WHAT

🤖 Generated by Copilot at 0676157

This pull request adds a feature to admit a patient to a facility after a completed shift in the shifting board component. It also refactors some imports and adds a utility function to check user authority in src/Common/utils.tsx. It updates the Common.json file with a new translation key for the admit button.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 0676157

  • Add checkAuthority utility function to compare user role with cutoff role (link)
  • Import checkAuthority function and transferPatient action in ShiftingBoard.tsx (link)
  • Import Notification functions and react-redux hooks in ShiftingBoard.tsx (link, link)
  • Select state and currentUser from redux store in ShiftingBoard.tsx (link)
  • Add isPatientTransfering state variable to manage loading and disabled state of admit patient button (link)
  • Add conditional rendering of admit patient button to ShiftCard component in ShiftingBoard.tsx (link)
  • Dispatch transferPatient action and display notification messages on button click in ShiftingBoard.tsx (link)
  • Add translation key and value for "admit_patient" in Common.json (link)
  • Remove console.log(shift) statement from ShiftingBoard.tsx (link)

@khavinshankar khavinshankar added urgent needs testing P1 breaking issue or vital feature labels Apr 25, 2023
@khavinshankar khavinshankar requested a review from a team April 25, 2023 11:38
@khavinshankar khavinshankar requested a review from a team as a code owner April 25, 2023 11:38
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 11:38am

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0676157
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6447bba5a8c5b60008fc3169
😎 Deploy Preview https://deploy-preview-5405--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 25, 2023
@gigincg
Copy link
Member

gigincg commented Apr 25, 2023

@khavinshankar This is completely out of line with the current working of Shifting.

@gigincg gigincg closed this Apr 25, 2023
@sainak sainak deleted the fix#5399 branch January 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure needs testing P1 breaking issue or vital feature urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Transfer patient records"- shifting module
2 participants