Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Illustration for Notice board when no notices available #5544

Closed
wants to merge 10 commits into from

Conversation

nikhilagastya
Copy link
Contributor

@nikhilagastya nikhilagastya commented May 26, 2023

Added a no notices available component which also redirects you to the home page

@nikhilagastya nikhilagastya requested a review from a team May 26, 2023 13:06
@nikhilagastya nikhilagastya requested a review from a team as a code owner May 26, 2023 13:06
@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2023 1:28pm

@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ad2ec8a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6472053a0d2eb200072c1284
😎 Deploy Preview https://deploy-preview-5544--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are introducing so many packages and also new material UI packages into the codebase. However, we are trying to get rid of material UI libraries entirely.

Try to achieve the same without using any new packages and use tailwind only.

Also, link issues to your PRs so that it's easier to track. Refer: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@nikhilagastya
Copy link
Contributor Author

You are introducing so many packages and also new material UI packages into the codebase. However, we are trying to get rid of material UI libraries entirely.

Try to achieve the same without using any new packages and use tailwind only.

Also, link issues to your PRs so that it's easier to track. Refer: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

alright I thought since material ui is already being used ,why not use it ,i will try to make a custom component with tailwind css
and about the packages I thought they would be helpful for a few features but didnt use them.

@nikhilagastya
Copy link
Contributor Author

@rithviknishad could you check this PR once!
Thankyou

@nikhilagastya nikhilagastya changed the title Illustration for Notice board when no notices available #3957 fixed Illustration for Notice board when no notices available #3957 May 26, 2023
@nikhilagastya nikhilagastya changed the title fixed Illustration for Notice board when no notices available #3957 fixed Illustration for Notice board when no notices available May 26, 2023
src/Components/Notifications/Notificationbell.png Outdated Show resolved Hide resolved
src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
@nikhilagastya
Copy link
Contributor Author

@rithviknishad can you check the PR for this issue.

src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
@nikhilagastya
Copy link
Contributor Author

@rithviknishad could you check if package-lock.json is fine now ?

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nikhilagastya
Copy link
Contributor Author

Hey @rithviknishad I have been looking forward to apply for C4GT and I have been working on my proposal , I had a few doubts ,so could we connect whenever you are free!
Thankyou

@rithviknishad
Copy link
Member

You can message any of us on the slack channel.

@nikhilagastya
Copy link
Contributor Author

can I get the link of the slack channel @rithviknishad

@nikhilagastya
Copy link
Contributor Author

duplicate to #4973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illustration for Notice board when no notices available
2 participants