-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed Illustration for Notice board when no notices available #5544
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are introducing so many packages and also new material UI packages into the codebase. However, we are trying to get rid of material UI libraries entirely.
Try to achieve the same without using any new packages and use tailwind only.
Also, link issues to your PRs so that it's easier to track. Refer: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
alright I thought since material ui is already being used ,why not use it ,i will try to make a custom component with tailwind css |
@rithviknishad could you check this PR once! |
@rithviknishad can you check the PR for this issue. |
@rithviknishad could you check if package-lock.json is fine now ? |
Kudos, SonarCloud Quality Gate passed! |
Hey @rithviknishad I have been looking forward to apply for C4GT and I have been working on my proposal , I had a few doubts ,so could we connect whenever you are free! |
You can message any of us on the slack channel. |
can I get the link of the slack channel @rithviknishad |
duplicate to #4973 |
Added a no notices available component which also redirects you to the home page