Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Illustration when no notices available + Replaced Material UI components in NoticeBoard page #5552

Merged
merged 22 commits into from
May 30, 2023
Merged

Adds Illustration when no notices available + Replaced Material UI components in NoticeBoard page #5552

merged 22 commits into from
May 30, 2023

Conversation

nikhilagastya
Copy link
Contributor

@nikhilagastya nikhilagastya commented May 28, 2023 •
edited by rithviknishad
Loading

Created custom components by removing Material UI

@nikhilagastya nikhilagastya requested a review from a team May 28, 2023 08:29
@nikhilagastya nikhilagastya requested a review from a team as a code owner May 28, 2023 08:29
@vercel
Copy link

vercel bot commented May 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 9:23am

@netlify
Copy link

netlify bot commented May 28, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 894a929
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6475c05cdb610200084e3368
😎 Deploy Preview https://deploy-preview-5552--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nikhilagastya nikhilagastya changed the title Closed Replace Material UI components in src/Components/Notifications/NoticeBoard.tsx Fixed Replace Material UI components in src/Components/Notifications/NoticeBoard.tsx May 28, 2023
@nikhilagastya
Copy link
Contributor Author

@rithviknishad can you please check the PR

rithviknishad
rithviknishad requested changes May 28, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are changes from #5544 present here?

Ensure your changes from other branches are not present.

src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
@nikhilagastya
Copy link
Contributor Author

Why are changes from #5544 present here?

Ensure your changes from other branches are not present.

yeahh ill change that

@nikhilagastya
Copy link
Contributor Author

@rithviknishad can you check if this is okay !

@rithviknishad
Copy link
Member

The changes from other branch are still present. Feel free to create a new branch and re-open another PR. This can mess up when the other PR and this PR merges.

@rithviknishad
Copy link
Member

Or you could make these changes in the other PR itself since that already removes some of the mui componennts, and link 2 issues to that PR if you are facing difficulty.

rithviknishad
rithviknishad requested changes May 29, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Care Icon's bell-slash icon instead of illustration.

changes requested by @nihal467

src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
src/Components/Notifications/NoticeBoard.tsx Outdated Show resolved Hide resolved
rithviknishad
rithviknishad requested changes May 29, 2023
View reviewed changes
public/images/Notificationbell.png Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

@nikhilagastya
image

  • This is a new design mock-up. Please try to adhere to this design and ensure that the content and text are center-aligned. Additionally, use the color grey-500.

@nikhilagastya
Copy link
Contributor Author

sure @nihal467 ill work on it

@nikhilagastya
Copy link
Contributor Author

@nihal467 @rithviknishad do we already have bell-slash in care icons ?

@rithviknishad
Copy link
Member

rithviknishad commented May 29, 2023 •
edited
Loading

@nikhilagastya all unicons are present in care icons. you just need to prefix the classname like: care-l-<icon_name>. Refer the #5006 to know more about care icons

@nikhilagastya
Copy link
Contributor Author

@rithviknishad kindly check if that works !

rithviknishad
rithviknishad approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nihal467
Copy link
Member

nihal467 commented May 30, 2023 •
edited
Loading

LGTM, great work @nikhilagastya

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 9c101cd into coronasafe:develop May 30, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
4 participants
@nikhilagastya @rithviknishad @nihal467 @khavinshankar