Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Temperature preference stored in local storage #5589

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

kunal00000
Copy link
Contributor

@kunal00000 kunal00000 commented Jun 2, 2023

WHAT

🤖 Generated by Copilot at f4b8d2a

The pull request adds a temperature unit preference feature to the user profile. It introduces a new TemperatureSelector component that handles the user's choice and uses it in the UserProfile component.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f4b8d2a

  • Add a new component TemperatureSelector to let the user choose between Celsius and Fahrenheit units for temperature (link)
  • Import and use the TemperatureSelector component in the UserProfile component, which shows and edits the user's profile information (link, link)
  • Style the TemperatureSelector component to match the form layout and background color in the UserProfile component (link)

@kunal00000 kunal00000 requested a review from a team June 2, 2023 18:58
@kunal00000 kunal00000 requested a review from a team as a code owner June 2, 2023 18:58
@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 7:14am

@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bcfdab2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/647edc89cecc710008198ba2
😎 Deploy Preview https://deploy-preview-5589--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add stricter types and refactor to move getTemperaturePreference to utils.
  2. Why have you not implemented code to use this preference in places where temperatures are shown?

src/Components/Common/TemperatureSelector.tsx Outdated Show resolved Hide resolved
src/Components/Common/TemperatureSelector.tsx Outdated Show resolved Hide resolved
src/Utils/utils.ts Outdated Show resolved Hide resolved
src/Components/Patient/DailyRounds.tsx Outdated Show resolved Hide resolved
src/Components/Common/TemperatureSelector.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Jun 7, 2023

LGTM

@khavinshankar khavinshankar merged commit 556875b into coronasafe:develop Jun 7, 2023
27 of 30 checks passed
@kunal00000 kunal00000 deleted the tempPreference branch June 7, 2023 18:37
rithviknishad added a commit that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Preference: Temperature Unit
4 participants