Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: Temperature preference stored in local storage (#5589)" #5707

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 16, 2023

This reverts commit 556875b.

WHAT

🤖 Generated by Copilot at 17d5b0d

This pull request removes the code and data related to temperature unit conversion and selection in various components and files. The purpose is to simplify the code and the UI, and to fix the temperature unit to Fahrenheit as the standard unit for the app. The pull request affects the following files: VirtualNursingAssistantLogUpdateCard.tsx, DailyRoundsList.tsx, DailyRoundListDetails.tsx, DailyRounds.tsx, LegacyPatientVitalsCard.tsx, UserProfile.tsx, TemperatureSelector.tsx, DevicePreference.tsx, models.tsx, and utils.ts.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 17d5b0d

  • Remove temperature unit preference and fix temperature unit to Fahrenheit
  • Remove imports and usage of TemperatureSelector from UserProfile component (link, link)
  • Remove imports and usage of getTemperaturePreference from DailyRoundsList, DailyRoundListDetails, and LegacyPatientVitalsCard components (link, link, link)
  • Remove temperatureUnit property from DailyRoundsModel interface (link)
  • Remove temperatureUnit property from API requests and responses in VirtualNursingAssistantLogUpdateCard, DailyRoundsList, DailyRoundListDetails, and LegacyPatientVitalsCard components (link, link, link, link, link)
  • Remove temperatureUnit display from UI in DailyRoundListDetails and LegacyPatientVitalsCard components (link, link)
  • Remove unused temperature conversion functions from utils file (link)
  • Fix typos and use consistent naming for tempInCelcius property in DailyRounds component (link, link, link, link, link)
  • Add local temperature conversion functions to DailyRounds component to allow user to toggle temperature unit (link)
  • Remove unused code for listening to local storage changes and toggling temperature unit in DailyRoundListDetails and DailyRounds components (link, link)
  • Use index as key instead of id for rendering DailyRoundsCard component in DailyRoundsList component (link)
  • Use consistent way of importing React hooks in DailyRoundListDetails component (link)

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 0:51am

@netlify
Copy link

netlify bot commented Jun 16, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 17d5b0d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648c5a9be301940008754d02
😎 Deploy Preview https://deploy-preview-5707--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad marked this pull request as ready for review June 16, 2023 13:09
@rithviknishad rithviknishad requested a review from a team June 16, 2023 13:09
@rithviknishad rithviknishad requested a review from a team as a code owner June 16, 2023 13:09
@rithviknishad rithviknishad added urgent P1 breaking issue or vital feature labels Jun 16, 2023
@khavinshankar khavinshankar merged commit a136866 into develop Jun 16, 2023
32 of 34 checks passed
@khavinshankar khavinshankar deleted the revert-5589 branch June 16, 2023 14:04
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed P1 breaking issue or vital feature urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants