Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress random fail [ Don't Merge ] #5638

Closed
wants to merge 3 commits into from
Closed

Cypress random fail [ Don't Merge ] #5638

wants to merge 3 commits into from

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Jun 9, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 0b3be56

Updated the patient CRUD tests to use a more reliable and faster testing framework (Cypress) and fixed potential test data issues by renaming the test patients.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 0b3be56

  • Refactor patient CRUD tests to use Cypress instead of Puppeteer (cypress/e2e/patient_spec/patient_crud.cy.ts)
    • Rename test patient from "Test E2E User" to "Test Cypress User" (link, link)

@nihal467 nihal467 requested a review from a team June 9, 2023 11:22
@nihal467 nihal467 requested a review from a team as a code owner June 9, 2023 11:22
@nihal467 nihal467 requested a review from gigincg June 9, 2023 11:22
@vercel
Copy link

vercel bot commented Jun 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 2:40pm

@netlify
Copy link

netlify bot commented Jun 9, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 083f240
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648339ade329120008b7a4cb
😎 Deploy Preview https://deploy-preview-5638--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member Author

nihal467 commented Jun 9, 2023 •
edited
Loading

image

  • Each Cypress test run individually for each PR is creating actual data in our staging,

@khavinshankar Currently, @Ashesh3 is looking into the issue

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 9, 2023
@Ashesh3 Ashesh3 mentioned this pull request Jun 9, 2023
Merged
@nihal467 nihal467 reopened this Jun 9, 2023
@nihal467 nihal467 closed this Jun 9, 2023
@sainak sainak deleted the Cypress-fail-test branch January 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nihal467