Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cypress test not using its own care backend #5639

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 9, 2023

WHAT

🤖 Generated by Copilot at 69bce85

Fixed the sed command in .github/workflows/cypress.yaml to remove double quotes from the target key in vite.config.ts. This prevents potential errors in the frontend configuration and testing.

Proposed Changes

Fixes #5638 (comment)

In vite.config.ts , We have the proxy in the following format:

target: "https://careapi.ohc.network"

To replace it with sed while configuring the Cypress test, the following pattern has to be used s^target: .* instead of the current "s^\"target\": .*. This is because we do not have the target wrapped around in quotes.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 69bce85

  • Remove double quotes from target key in vite.config.ts file to avoid errors in JavaScript object syntax (link)

@Ashesh3 Ashesh3 requested a review from a team June 9, 2023 11:57
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 9, 2023 11:57
@Ashesh3 Ashesh3 requested a review from bodhish June 9, 2023 11:57
@vercel
Copy link

vercel bot commented Jun 9, 2023

@Ashesh3 is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 69bce85
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648313c28580340008958614
😎 Deploy Preview https://deploy-preview-5639--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khavinshankar khavinshankar merged commit 2333d80 into coronasafe:develop Jun 9, 2023
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants