Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release: SmartICU Hotfixes #5727

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Production Release: SmartICU Hotfixes #5727

merged 4 commits into from
Jun 20, 2023

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Jun 20, 2023

WHAT

🤖 Generated by Copilot at 66a14c0

This pull request fixes some UI and validation issues in the auth, facility, and vitals monitor components. It also refactors some common components to separate files for better code organization and reusability. The files affected are Login.tsx, ResetPassword.tsx, UpdateFacilityMiddleware.tsx, UserAdd.tsx, and HL7PatientVitalsMonitor.tsx.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 66a14c0

  • Correct the error message for the username field in the login component to use the translation key field_required (link)
  • Remove the redundant required attribute from the password field in the login component (link)
  • Remove the unused import of LegacyErrorHelperText from the reset password component (link)
  • Add the imports of validateRule and validatePassword to the reset password component to implement the new password validation logic and UI (link)
  • Replace the state variables passReg and setPassReg with passwordInputInFocus and confirmPasswordInputInFocus to track the focus state of the password and confirm password fields in the reset password component (link)
  • Replace the regex for validating the password with a call to validatePassword in the reset password component (link)
  • Replace the CollapseV2 component with a conditional rendering of the validateRule component to show the password requirements in the reset password component, and add the onFocus and onBlur handlers to the password field to update the focus state (link)
  • Remove the LegacyErrorHelperText component and add a conditional rendering of the validateRule component to show the error for the confirm password field in the reset password component, and add the onFocus and onBlur handlers to the confirm password field to update the focus state (link)
  • Add the errors property to the initial state of the update facility middleware component to store and display the validation errors for the middleware address field (link)
  • Replace the Notification.Error calls with dispatch actions that set the error in the state for the empty or invalid middleware address field in the update facility middleware component (link, link)
  • Add the error prop to the input field component for the middleware address in the update facility middleware component, which takes the error from the state and displays it as a helper text (link)
  • Move the validateRule component from the user add component to a separate file, as it is reused in the reset password component and could be a common component for other validation scenarios (link, link)
  • Fix the typo in the color prop for the Resp channel in the HL7 patient vitals monitor component, and make it consistent with the SpO2 channel (link)

@gigincg gigincg requested a review from a team June 20, 2023 05:59
@gigincg gigincg requested a review from a team as a code owner June 20, 2023 05:59
@gigincg gigincg requested a review from bodhish June 20, 2023 05:59
@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Jun 20, 2023 5:59am

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 66a14c0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6491405042d1b40008b01763
😎 Deploy Preview https://deploy-preview-5727--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gigincg gigincg merged commit 458563d into master Jun 20, 2023
33 of 34 checks passed
@github-actions
Copy link

@gigincg We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants