Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bug): Disabled field in Add Consultation in removed from Patient Details page #5837

Closed
wants to merge 0 commits into from
Closed

fix(bug): Disabled field in Add Consultation in removed from Patient Details page #5837

wants to merge 0 commits into from

Conversation

Rhythm-08
Copy link

@Rhythm-08 Rhythm-08 commented Jul 4, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 4dccbac

This pull request improves the user interface and functionality of the patient home page. It fixes the logic for showing and accessing the consultation and discharge buttons, and adds some style to the chat button in PatientHome.tsx.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.

HOW

🤖 Generated by Copilot at 4dccbac

  • Fix logical error in enabling and navigating to consultation button for active patients with no consultation or consultation with no discharge date (link, link)
  • Fix logical error in enabling discharge button for active patients with consultation with no discharge date (link)

@Rhythm-08 Rhythm-08 requested a review from a team July 4, 2023 18:32
@Rhythm-08 Rhythm-08 requested a review from a team as a code owner July 4, 2023 18:32
@vercel
Copy link

vercel bot commented Jul 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 8:54am

@netlify
Copy link

netlify bot commented Jul 4, 2023 •
edited
Loading

❌ Deploy Preview for care-egov-staging failed.

Name Link
🔨 Latest commit 4bc182d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64bff93e5c8f30000819d9e0

@Rhythm-08
Copy link
Author

can anyone tell me how is these checks are failing in my pull request, because I'm not able to get where am I wrong in this and how should I improve it?

@nihal467
Copy link
Member

@Rhythm-08
image

  • the add consultation button should be disabled when there is a active consultation for a patient

@Rhythm-08
Copy link
Author

@Rhythm-08
image

  • the add consultation button should be disabled when there is a active consultation for a patient

Thanks, I will get on to solve this 👍

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jul 25, 2023
@github-actions
Copy link

👋 Hi, @Rhythm-08,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Rhythm-08 Rhythm-08 closed this Jul 25, 2023
@Rhythm-08 Rhythm-08 force-pushed the develop branch 2 times, most recently from 9de2f27 to 4bc182d Compare July 25, 2023 16:32
@netlify
Copy link

netlify bot commented Jul 25, 2023

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 4bc182d
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/64bff93d68949800081d2131

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jul 25, 2023
@Sushreebadhulika Sushreebadhulika mentioned this pull request Oct 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict test failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Consultation is permanently disabled in Patient Details page
2 participants
@Rhythm-08 @nihal467