Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Min. Respiratory Rate to 0 #5931

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Set Min. Respiratory Rate to 0 #5931

merged 7 commits into from
Jul 28, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jul 26, 2023

WHAT

🤖 Generated by Copilot at 1d01622

This pull request updates the respiratory rate input components in CriticalCare__HemodynamicParametersEditor.res and DailyRounds.tsx to allow zero as a valid value. It also fixes a minor CSS bug in Uptime.tsx.

Proposed Changes

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 1d01622

  • Lower the minimum value of the respiratory rate slider and validation function from 10 to 0 in the hemodynamic parameters editor and the daily rounds components (link, link, link). This allows the user to enter zero as a valid input for the respiratory rate in cases of mechanical ventilation or apnea.

@Ashesh3 Ashesh3 requested a review from a team July 26, 2023 07:24
@Ashesh3 Ashesh3 requested a review from a team as a code owner July 26, 2023 07:24
@Ashesh3 Ashesh3 requested a review from bodhish July 26, 2023 07:24
@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 8:28am

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a02a595
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c37bf75e05d400085f5a61
😎 Deploy Preview https://deploy-preview-5931--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added cypress failed pull request with cypress test failure and removed cypress passed labels Jul 26, 2023
@Ashesh3 Ashesh3 changed the title Set Min. Respiratory Rate to 1 Set Min. Respiratory Rate to 0 Jul 27, 2023
@Ashesh3 Ashesh3 removed the blocked label Jul 27, 2023
@github-actions github-actions bot added cypress passed cypress failed pull request with cypress test failure and removed cypress failed pull request with cypress test failure cypress passed labels Jul 27, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 849b58e into develop Jul 28, 2023
29 checks passed
@khavinshankar khavinshankar deleted the fix-5926 branch July 28, 2023 09:56
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add value from 1 onwards to respiratory field in log update
3 participants