Set Minimum Value to 0 for Respiratory Rate Field in DailyRound Model #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainak
approved these changes
Jul 26, 2023
rithviknishad
approved these changes
Jul 26, 2023
gigincg
requested changes
Jul 26, 2023
Ashesh3
changed the title
Ashesh3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for: coronasafe/care_fe#5931
Proposed Changes
This PR modifies the validators for the
respfield in thedaily_round.pymodel. Previously, therespfield had a minimum valid value of 10, which may not have accommodated all possible real-world values for respiratory rates.MinValueValidatorfor therespfield has been changed from 10 to 1.The
MaxValueValidatorremains unchanged at 70. This change allows for a wider range of valid inputs, increasing the flexibility of our data collection.This change does not affect any other part of the
daily_round.pymodel, or any other models in the application.Associated Issue
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins