Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve discharge summary notifications #5954

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented Jul 27, 2023

WHAT

🤖 Generated by Copilot at 473a01a

This pull request enhances the discharge summary modal component in DischargeSummaryModal.tsx. It improves the feedback, performance, and consistency of the modal with the backend.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 473a01a

  • Add error handling for discharge summary not ready case (link)
  • Increase timeout for polling function from 5 to 7 seconds (link)
  • Update expected status code for email request from 200 to 202 (link)

Signed-off-by: Aakash Singh <mail@singhaakash.dev>
@sainak sainak requested a review from a team July 27, 2023 12:47
@sainak sainak requested a review from a team as a code owner July 27, 2023 12:47
@sainak sainak requested a review from gigincg July 27, 2023 12:47
@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 8:17am

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fda966b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c37947cb4b710008bf2c04
😎 Deploy Preview https://deploy-preview-5954--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Jul 28, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit e989a05 into develop Jul 28, 2023
29 checks passed
@khavinshankar khavinshankar deleted the sainak/fix/discharge-smmary branch July 28, 2023 09:54
@github-actions
Copy link

@sainak We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discharge summary is not generated properly in production
3 participants