Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup fireRequests and remove axios #6003

Closed
wants to merge 9 commits into from
Closed

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 4, 2023

WHAT

🤖 Generated by Copilot at ca617a1

This pull request replaces axios with fetch for making HTTP requests throughout the codebase, and removes the axios dependency from the package.json file. This improves the performance, compatibility, and consistency of the HTTP requests and reduces the code complexity. It also fixes some minor issues with the routes and authentication in the api.tsx file.

Proposed Changes

  • Replace axios with native fetch

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at ca617a1

@sainak sainak requested a review from a team August 4, 2023 16:21
@sainak sainak requested a review from a team as a code owner August 4, 2023 16:21
@sainak sainak requested a review from gigincg August 4, 2023 16:21
@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 0:02am

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fee12b3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65156b0fe776980008a7a0e9
😎 Deploy Preview https://deploy-preview-6003--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Aug 4, 2023
@sainak sainak mentioned this pull request Aug 4, 2023
10 tasks
@nihal467
Copy link
Member

nihal467 commented Aug 9, 2023

@sainak check the cypress issue

@khavinshankar
Copy link
Member

@rithviknishad @Ashesh3 can you please review this pr once

src/Redux/fireRequest.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 16, 2023
@github-actions
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 24, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@sainak sainak added cypress failed pull request with cypress test failure and removed Cypress Test Pending The Cypress test are to be verified labels Sep 28, 2023
@nihal467
Copy link
Member

nihal467 commented Oct 3, 2023

@sainak
image

https://deploy-preview-6003--care-net.netlify.app/facility/45d45bb6-c48e-4883-984d-ac602ef7df1e/patient/5ea5550d-acc3-426e-888f-42f0ed58b705/consultation/debbce92-7670-45c0-93e4-82cd92241a6c/feed

  • when I try to move a camera to a fixed preset, the moving symbol stuck in the loading state post moving to the preset position. In existing staging, there is no issue like that.

Note: This issue was only observed while moving to a preset, but manual controls are working fine

image

  • unable to upload a facility cover image

image

  • critical care page is not at all loading

https://deploy-preview-6003--care-net.netlify.app/facility/45d45bb6-c48e-4883-984d-ac602ef7df1e/patient/5ea5550d-acc3-426e-888f-42f0ed58b705/consultation/debbce92-7670-45c0-93e4-82cd92241a6c/daily_rounds/4a42ec26-3dd0-4998-8b6f-4fbd9ba96e27/update

CC: @rithviknishad

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 4, 2023
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 11, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Oct 18, 2023
@sainak sainak reopened this Oct 18, 2023
@github-actions github-actions bot removed the stale label Oct 19, 2023
@nihal467
Copy link
Member

@sainak any ETD for this PR status, as its been stale with no activity for 3 weeks ?

Copy link

github-actions bot commented Nov 3, 2023

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 3, 2023
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Nov 11, 2023
@Ashesh3
Copy link
Member

Ashesh3 commented Dec 5, 2023

@sainak any ETD for this PR status, as its been stale with no activity for 3 weeks ?

^ @sainak

cc: @nihal467

@sainak sainak deleted the sainak/replace-axios branch December 5, 2023 19:25
@sainak sainak restored the sainak/replace-axios branch December 5, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed Major Code Change This Tag represent PR, which will be causing major Code change in the platform merge conflict pull requests with merge conflict stale test failed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants