Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add front-end validation for location creation form #6043

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 10, 2023

WHAT

🤖 Generated by Copilot at 2d87d68

Added form validation for name field in AddLocationForm.tsx. Refactored handleSubmit and setErrors functions to improve code readability and user feedback.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 2d87d68

  • Add a validateForm function to check the name input field and set the error state (link)
  • Modify the handleSubmit function to call validateForm and return early if the form is not valid (link)
  • Move the setErrors call from handleSubmit to validateForm (link)
  • Improve the user experience and prevent sending invalid data to the backend by validating the form in AddLocationForm.tsx (link)

@Ashesh3 Ashesh3 requested a review from a team August 10, 2023 08:50
@Ashesh3 Ashesh3 requested a review from a team as a code owner August 10, 2023 08:50
@Ashesh3 Ashesh3 requested a review from gigincg August 10, 2023 08:50
@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 8:51am

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2d87d68
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64d4a4d40adc5f00096415cb
😎 Deploy Preview https://deploy-preview-6043--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 6efe2b2 into develop Aug 16, 2023
36 checks passed
@khavinshankar khavinshankar deleted the fix-6041 branch August 16, 2023 08:04
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add front-end validation for location creation form
3 participants