Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responsive design to Update Asset Service Record modal #6166

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Aug 28, 2023

WHAT

🤖 Generated by Copilot at 4baad12

Refactor the AssetServiceEditModal component to use better buttons. This improves the UI and the code quality of the asset service editing feature.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 4baad12

  • Import two new components, Cancel and Submit, from ButtonV2 module to render modal buttons (link)
  • Replace ButtonV2 components with Cancel and Submit components in AssetServiceEditModal.tsx and adjust layout to use flex column or row depending on screen size (link)

@Pranshu1902 Pranshu1902 requested a review from a team August 28, 2023 09:04
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 28, 2023 09:04
@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 9:04am

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4baad12
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64ec63023246d200080e87f0
😎 Deploy Preview https://deploy-preview-6166--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f8dcf1f into coronasafe:develop Aug 30, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add responsive design to Update Asset Service Record modal
3 participants