Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for direnv and use CARE_API from env in vite config #6201

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Support for direnv and use CARE_API from env in vite config #6201

merged 6 commits into from
Sep 5, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 1, 2023 •
edited
Loading 

# .env.local

CARE_API=http://127.0.0.1:8000
image

@rithviknishad rithviknishad requested a review from a team September 1, 2023 06:30
@rithviknishad rithviknishad requested a review from a team as a code owner September 1, 2023 06:30
@vercel
Copy link

vercel bot commented Sep 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 1:43am

@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8e5396d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f53607df19c2000878ead7
😎 Deploy Preview https://deploy-preview-6201--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sainak
Copy link
Member

sainak commented Sep 1, 2023

@rithviknishad

care_fe/.github/workflows/cypress.yaml

Line 39 in c3f3ce5

run: 'sed --in-place "s^target: .*,^target: \"http://localhost:9000\",^g" vite.config.ts'

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Sep 1, 2023
sainak
sainak reviewed Sep 1, 2023
View reviewed changes
vite.config.ts Show resolved Hide resolved
@sainak
Copy link
Member

sainak commented Sep 1, 2023

We should add direnv as well

@sainak
Copy link
Member

sainak commented Sep 1, 2023

test -f .env.local && dotenv .env.local

@rithviknishad rithviknishad changed the title Vite Config: Use CARE_API from env Support for direnv and use CARE_API from env in vite config Sep 1, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Sep 4, 2023
@khavinshankar khavinshankar merged commit bbb07b7 into develop Sep 5, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the careapi-env branch September 5, 2023 15:12
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@sainak sainak sainak approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress passed good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rithviknishad @sainak @Ashesh3 @khavinshankar @nihal467