Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra loader and add success notification on link skills page #6210

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Sep 3, 2023

WHAT

🤖 Generated by Copilot at 77c103e

This pull request enhances the skills management feature for users in care_fe. It improves the UI and feedback in SkillsSlideOver.tsx and fixes some minor bugs.

Proposed Changes

Screenshot from 2023-09-03 14-20-40
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 77c103e

  • Add a success notification when a skill is added to a user (link)
  • Prevent the UI from jumping and showing an empty select while fetching the skills by moving the loading indicator inside the tooltip div and rendering the skill select and the add button only when the loading is finished (link)
  • Avoid showing the tooltip text when the user can add skills by moving it inside the button div and rendering it only when the button is disabled (link)

@Pranshu1902 Pranshu1902 requested a review from a team September 3, 2023 08:52
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner September 3, 2023 08:52
@vercel
Copy link

vercel bot commented Sep 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2023 8:53am

@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 77c103e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f44947e6a251000831941f
😎 Deploy Preview https://deploy-preview-6210--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pranshu1902 Pranshu1902 changed the title remove extra loader and add success notification Remove extra loader and add success notification on link skills page Sep 3, 2023
@nihal467
Copy link
Member

nihal467 commented Sep 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 1631e79 into coronasafe:develop Sep 5, 2023
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Skill shows so many loaders and no success Notification
4 participants