Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor App.tsx, Providers, Integrations; Remove usage on redux's states; Adds support for notifications to useQuery and request #6287

Merged
merged 10 commits into from
Sep 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 14, 2023

WHAT

🤖 Generated by Copilot at fca61b5

This pull request refactors the codebase to improve the organization, readability, and testability of the components. It extracts some logic from the App component into custom providers and routers, and moves and renames some components to new folders. It also updates the import paths and types for the config, currentUser, Sentry, Plausible, and HistoryAPIProvider components.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at fca61b5

  • Refactor App component to use custom providers and routers (link)
  • Extract Sentry component to handle Sentry service initialization and configuration (link, link)
  • Extract Plausible component to handle Plausible service initialization and configuration (link, link)
  • Extract AppConfigProvider component to handle app config fetching and providing (link, link, link, link)
  • Extract AuthUserProvider component to handle current user fetching, providing, and refreshing (link, link, link, link)
  • Extract ThemedFavicon component to handle favicon switching based on color scheme (link)
  • Move HistoryAPIProvider component to Providers folder and update export and declaration (link, link, link, link)
  • Move AppRouter and SessionRouter components to Routers folder and update exports (link, link, link)
  • Update import paths of triggerGoal function from Plausible component in various components (link, link, link, link, link)
  • Remove TODO comment from useFilters hook as it is no longer relevant (link)

@rithviknishad rithviknishad marked this pull request as ready for review September 14, 2023 07:05
@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 3:10am

@rithviknishad rithviknishad requested a review from a team September 14, 2023 07:05
@rithviknishad rithviknishad requested a review from a team as a code owner September 14, 2023 07:05
@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4842e06
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/650a6288b6bd98000857d4bb
😎 Deploy Preview https://deploy-preview-6287--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 14, 2023

Passing run #1282 ↗︎

0 75 0 0 Flakiness 0

Details:

Refactor `App.tsx`, Providers, Integrations; Remove usage on redux's states; Add...
Project: CARE Commit: 4842e06ca3
Status: Passed Duration: 03:20 💡
Started: Sep 20, 2023 3:15 AM Ended: Sep 20, 2023 3:19 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@rithviknishad rithviknishad marked this pull request as ready for review September 19, 2023 10:38
@rithviknishad rithviknishad changed the title Refactor App.tsx, Providers, Integrations & Remove usage on redux's states Refactor App.tsx, Providers, Integrations; Remove usage on redux's states; Adds support for notifications to useQuery and request Sep 19, 2023
@nihal467
Copy link
Member

@rithviknishad the cypress is failing look into it

@nihal467
Copy link
Member

@rithviknishad the cypress is failing

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 5c8d4f9 into develop Sep 21, 2023
33 of 35 checks passed
@khavinshankar khavinshankar deleted the refactor-app branch September 21, 2023 04:38
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants