Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group medicine administration by 4 hours + Support for archiving medicines + Administration Activity View + migrate useDispatch to useQuery #6396

Merged
merged 47 commits into from
Nov 6, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 4, 2023

WHAT

🤖 Generated by Copilot at 1f75446

Improved the usability and responsiveness of the PrescriptionAdministrationsTable component by changing the pagination logic and layout to show full days of data.

Required Backends

Proposed Changes

image image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 1f75446

  • Import useBreakpoints hook to determine the number of days per page based on screen size (link)
  • Declare daysPerPage variable using useBreakpoints hook with default value of 1 and higher values for larger screens (link)
  • Update usePagination hook to use daysPerPage variable for perPage and slots properties, which represent the pagination range and the table columns respectively (link)
  • Modify getAdministrationBounds function to round the pagination range to whole days instead of hours, to align with daysPerPage variable (link)

@rithviknishad rithviknishad requested a review from a team October 4, 2023 14:04
@rithviknishad rithviknishad requested a review from a team as a code owner October 4, 2023 14:04
@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 0:04am

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6cfd3e0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6548d639d15e260008a42041
😎 Deploy Preview https://deploy-preview-6396--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Oct 4, 2023

Passing run #1525 ↗︎

0 82 0 0 Flakiness 0

Details:

Group medicine administration by 4 hours + Support for archiving medicines + Adm...
Project: CARE Commit: 6cfd3e0a20
Status: Passed Duration: 03:47 💡
Started: Nov 6, 2023 12:07 PM Ended: Nov 6, 2023 12:11 PM

Review all test suite changes for PR #6396 ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Nov 2, 2023
@nihal467
Copy link
Member

nihal467 commented Nov 6, 2023

@rithviknishad
image

add a medicine and discontinue it, the count in the hidden prescription wont get auto updated, even though the medicine is hidden now, unless we do a manual reload of page

image

in mobile view the prescription data seems to be overflowing outside the padding

image

hide archive button for the discontinued medicine

@khavinshankar khavinshankar merged commit fbf8eee into develop Nov 6, 2023
54 of 57 checks passed
@khavinshankar khavinshankar deleted the mar-binning branch November 6, 2023 13:51
Copy link

github-actions bot commented Nov 6, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed Major Code Change This Tag represent PR, which will be causing major Code change in the platform tested
Projects
None yet
3 participants