Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Administer Medicine responsive view #6460

Closed
wants to merge 3 commits into from

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Oct 17, 2023

WHAT

🤖 Generated by Copilot at 907d053

This pull request improves the responsiveness and layout of various components related to medicine and prescription details. It adjusts the grid columns, whitespace, and wrapping of text elements in PrescriptionDetailCard.tsx, RecordMeta.tsx, and AdministerMedicine.tsx.

Proposed Changes

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 907d053

  • Prevent user name from wrapping in record meta by adding whitespace-nowrap class to span element (link)
  • Make label text responsive in administer medicine form by adding md: prefix to whitespace-nowrap class in CheckBoxFormField component (link)
  • Make prescription details more compact and consistent in PrescriptionDetailCard component by modifying grid layout classes in Detail components (link, link, link, link, link, link, link)

@Pranshu1902 Pranshu1902 requested a review from a team October 17, 2023 08:48
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner October 17, 2023 08:48
@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 10:16am

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4334bb7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653a3c6f2818e90008db0f74
😎 Deploy Preview https://deploy-preview-6460--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@Pranshu1902
image

in normal view, the administration not specified is over flowing

@Pranshu1902
Copy link
Contributor Author

@nihal467 check now

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Oct 26, 2023

@nihal467 Updated view
The values are large so its best to make it full width
image

@rithviknishad
Copy link
Member

@Pranshu1902 @nihal467 These changes are likely to be already fixed in #6396

Could you test the following deploy preview? Changes in #6396 are huge and some files have been deleted/moved too. Conflicts might be chaos / practically a rework. https://deploy-preview-6396--care-net.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/medicines

@rithviknishad
Copy link
Member

This design has lots of screenspace wasted IMO

@nihal467 Updated view The values are large so its best to make it full width image

@Pranshu1902
Copy link
Contributor Author

Closing the PR as fixed in #6396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Administer Medicine Slider and Modal not responsive
3 participants