Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename assets dir to avoid conflicts with /assets/ route #6501

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

sainak
Copy link
Member

@sainak sainak commented Oct 26, 2023

WHAT

🤖 Generated by Copilot at 63d9d8f

Set assetsDir to "bundle" in vite.config.ts to fix static asset serving on subpath deployment.

Proposed Changes

rename directory for generated js assets to avoid route conflict in nginx

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 63d9d8f

  • Set the assetsDir option to "bundle" in the vite config file vite.config.ts to fix the issue of static assets not being served correctly on a subpath (link)

@sainak sainak requested a review from a team October 26, 2023 10:04
@sainak sainak requested a review from a team as a code owner October 26, 2023 10:04
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 63d9d8f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653a39a6ddcdb90008e6425f
😎 Deploy Preview https://deploy-preview-6501--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Oct 26, 2023 10:04am

@khavinshankar khavinshankar merged commit 536d161 into develop Oct 26, 2023
27 of 29 checks passed
@khavinshankar khavinshankar deleted the sainak/fix/nginx-assets branch October 26, 2023 10:13
@github-actions
Copy link

@sainak We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nginx deployments return 403 on /assets/
2 participants