Replace useDispatch w. useQuery/request: Notifications (src/Components/Notifications/**) #6392 #6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 26, 2023 15:07
…on the comments, add model.tsx in to folder notifications and add references into api.tsx
…patch with useQuery
…patch with useQuery, delete all commnets of old code
…lete all commnets of old code
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adriansliva
changed the title
rithviknishad
requested changes
Nov 6, 2023
|
@adriansliva could you also rebase and clear the merge conflicts? |
rithviknishad
requested changes
Nov 6, 2023
rithviknishad
approved these changes
Nov 6, 2023
|
lgtm |
khavinshankar
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 97346d7
This pull request refactors the notifications components to use custom hooks and functions for fetching and handling data from the API, and adds TypeScript interfaces and ESLint configuration for improving the code quality and readability. It modifies the files
NoticeBoard.tsx,NotificationsList.tsx,ShowPushNotification.tsx,api.tsx,.eslintrc.jsandmodels.tsx.This pull request improves the code quality and readability of the Notifications components.
Proposed Changes
useDispatchw.useQuery/request: Notifications (src/Components/Notifications/**) #6392@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 97346d7
dispatchcalls withuseQueryhook to fetch notifications data inNoticeBoardcomponent (link, link)useEffect,useStateanduseDispatchfromNoticeBoardandNotificationsListcomponents (link, link)requestfunction androutesobject to make API requests and specify types inNotificationsListcomponent (link)dispatchcalls withrequestfunction to mark notifications as read, get and update push notification configuration, and get public key inNotificationsListcomponent (link, link, link, link, link, link, link)dispatchvariables fromNotificationTileandNotificationsListcomponents (link, link)dispatchdependency fromuseEffecthook inNotificationsListcomponent (link)useDispatchhook withuseQueryhook to fetch notification data and redirect inShowPushNotificationcomponent (link)useEffecthook fromShowPushNotificationcomponent as it is redundant (link)methodandTResproperties to notification routes inroutesobject to specify HTTP methods and response types (link, link, link)modelsfile inapi.tsxfile to use them for route types (link)