Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Replace useDispatch w. useQuery/request: Notifications (src/Components/Notifications/**) #6392

Closed
Tracked by #6316
rithviknishad opened this issue Oct 4, 2023 · 16 comments · Fixed by #6543
Closed
Tracked by #6316
Assignees
Labels
good first issue Good for newcomers

Comments

@rithviknishad
Copy link
Member

No description provided.

@adriansliva
Copy link
Contributor

Hi can you please assign me this issue?

@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Oct 19, 2023
@adriansliva
Copy link
Contributor

sorry for the inactivity but I'm working on it, the solution will be ready in the next few days

@adriansliva
Copy link
Contributor

specifically today I will add the first solution

@github-actions github-actions bot removed the stale label Oct 21, 2023
@shyamprakash123
Copy link
Contributor

@adriansliva are you still working on this? If not @rithviknishad I would like to work on this, can you assign me?

@adriansliva
Copy link
Contributor

@shyamprakash123 im still working on this issue

@adriansliva
Copy link
Contributor

adriansliva commented Oct 26, 2023

I must have this issue because it relates to a subject at the university I am studying at and I can no longer change the role I have chosen. Until recently I didn't have time to solve it, but I have already started working on its implementation. thank you for your understanding @shyamprakash123.

@adriansliva
Copy link
Contributor

@rithviknishad I can't push the changes I created in the code
I created my own branch and I'm trying to put what I made into it but it doesn't work. Can you help or advise me thank you

@rithviknishad
Copy link
Member Author

@adriansliva You'll have to make the branch in your fork in order to be able to push.

Refer: https://docs.github.com/en/get-started/quickstart/contributing-to-projects

@adriansliva
Copy link
Contributor

Hi @rithviknishad I edited all components in the Notifications folder (change useDispatch). This is my fork https://github.com/adriansliva/issue-6392, and should I now create a branch?

I apologize for the delay in editing the code. Thanks for your answer.

@rithviknishad
Copy link
Member Author

Yes. You can now

  1. Create the branch
  2. Push your changes to the branch
  3. Open a PR in this repository from your branch.

@adriansliva
Copy link
Contributor

adriansliva commented Nov 5, 2023

@rithviknishad I created a pull request for the issue. What are the next steps?

@rithviknishad
Copy link
Member Author

@adriansliva the PR will be reviewed and QA testing will be done. If any changes are requested, you'll have to follow up on it. Once the tested label is added, it'll be merged anytime in the same week.

@rithviknishad
Copy link
Member Author

@adriansliva I've reviewed and requested some changes to the PR

khavinshankar pushed a commit that referenced this issue Nov 7, 2023
…s/Notifications/**) #6392 (#6543)

* Add only imports. other functionality and changes in code to be complited later

* ShowPushNotification - change useDispatch with useQuery, old code is on the comments, add model.tsx in to folder notifications and add references into api.tsx

* Complete ShowPushNotification.tsx and NoticeBoard.tsx - change useDispatch with useQuery

* Complete ShowPushNotification.tsx and NoticeBoard.tsx - change useDispatch with useQuery, delete all commnets of old code

* Complete NotificationsList.tsx - change useDispatch with useQuery, delete all commnets of old code

* deleting all comments

* code modification according to requests

* back the original content of package-lock.json from origin branch

---------

Co-authored-by: Adrián Sliva <adrian.sliva@student.tuke.sk>
@adriansliva
Copy link
Contributor

Hi @rithviknishad could I ask you 2 questions. I need to find out information about the project. I need this in the context of creating a presentation for a subject in school in which we had to address an issue. I would be grateful for your answers to these questions if it is within your competence and capabilities.

Question 1 - What DevOps services and tools does your project use? For each tool, please write how it is used in the project.

Question 2 - What was the test coverage like? Provide "covered lines" metrics - absolute or relative (if you measured them).

@rithviknishad
Copy link
Member Author

rithviknishad commented Nov 21, 2023

Question 1 - What DevOps services and tools does your project use? For each tool, please write how it is used in the project.

You can see all the CI/CD actions here: care_fe/actions and care/actions

@sainak should be able to provide you links to the deploy docs which you can refer to.

Question 2 - What was the test coverage like? Provide "covered lines" metrics - absolute or relative (if you measured them).

@adriansliva we don't have "covered lines" metrics for the front-end. However we do have one for the backend, which you can see from here. https://app.codecov.io/gh/coronasafe/care

cc: @nihal467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
3 participants