Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scroll overlay. #6598

Closed
wants to merge 5 commits into from
Closed

Fix scroll overlay. #6598

wants to merge 5 commits into from

Conversation

AshrafMd-1
Copy link
Contributor

@AshrafMd-1 AshrafMd-1 commented Nov 14, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 2817c98

Improved UI and UX of MedicineAdministrationSheet component. Removed unnecessary overlay and repositioned discontinued prescriptions button.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 2817c98

  • Disable the overlay of the medicine administration sheet component when there is only one prescription to view, in addition to the existing conditions of loading or no prescriptions. This prevents the user from accidentally closing the sheet by clicking on the overlay. (link)

@AshrafMd-1 AshrafMd-1 requested a review from a team November 14, 2023 13:08
@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner November 14, 2023 13:08
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 2:23pm

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 804609d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655625b9404b410008a424ab
😎 Deploy Preview https://deploy-preview-6598--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad once can you review this

@nihal467
Copy link
Member

Initiated cypress once again to check failure - 14:06 21/11/2023

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 21, 2023
@github-actions GitHub Actions
Copy link

👋 Hi, @AshrafMd-1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@AshrafMd-1
Copy link
Contributor Author

This PR is already solved by other PR so closing this

@AshrafMd-1 AshrafMd-1 closed this Nov 21, 2023
@AshrafMd-1 AshrafMd-1 deleted the Fix-#6590 branch November 21, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consultation Medicine Tab: Displays "Scroll for more prescription" even during a single prescription.
3 participants
@AshrafMd-1 @nihal467 @rithviknishad