Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default ordering value #6656

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Nov 16, 2023

WHAT

🤖[deprecated] Generated by Copilot at c1c850b

Fixed patient list sorting bug by removing default ordering value. The ordering parameter for the PatientManager component is now determined by the TableHeader component.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at c1c850b

  • Change the default value of ordering in PatientManager to undefined to fix sorting bug (link)

@GokulramGHV GokulramGHV requested a review from a team November 16, 2023 12:56
@GokulramGHV GokulramGHV requested a review from a team as a code owner November 16, 2023 12:56
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2024 11:58am

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 73410cf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6627766b69cde50008144c4b
😎 Deploy Preview https://deploy-preview-6656--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Nov 22, 2023

image

It is not working for readmission patients @GokulramGHV @rithviknishad

@nihal467
Copy link
Member

@GokulramGHV can you fix the issue ASAP

@GokulramGHV
Copy link
Member Author

@nihal467 I'll fix it by today

@nihal467
Copy link
Member

nihal467 commented Jan 1, 2024

LGTM

@nihal467 nihal467 added reviewed reviewed by a core member and removed needs review labels Jan 23, 2024
Copy link

vercel bot commented Apr 23, 2024

@nihal467 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 4263dae into coronasafe:develop Apr 24, 2024
27 of 29 checks passed
Copy link

@GokulramGHV Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort "No Consultation Filed" patients to the top of Patient List page
5 participants