Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable critical care submit if only basic editor is filled #6860

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Dec 13, 2023

WHAT

🤖[deprecated] Generated by Copilot at 99c20f7

Added a disabled attribute to the button element in CriticalCare__Recording.res to avoid filing empty changes. This improves the performance and usability of the critical care recording feature.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 99c20f7

  • Add disabled attribute to button element to prevent filing unchanged data (link)

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 6:20am

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6f62d27
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6581360153b6050008ffba8e
😎 Deploy Preview https://deploy-preview-6860--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@Pranshu1902
image

the copy previous value to critical care is not working

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Dec 15, 2023

@nihal467 copy from previous records seems to be working fine for me
Probably check whether the patient you are testing on has a previous record of Critical Care
I tried on patient Gigin
https://deploy-preview-6860--care-egov-staging.netlify.app/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e

image
image

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 7c21b80 into coronasafe:develop Dec 20, 2023
36 checks passed
Copy link

@Pranshu1902 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User shouldn't be able to submit an empty Record Update
4 participants