Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced useDispatch with useQuery/request in Inventory Management #7041

Merged
merged 20 commits into from
Jan 31, 2024
Merged

Replaced useDispatch with useQuery/request in Inventory Management #7041

merged 20 commits into from
Jan 31, 2024

Conversation

sriharsh05
Copy link
Contributor

@sriharsh05 sriharsh05 commented Jan 16, 2024 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sriharsh05 sriharsh05 requested a review from a team as a code owner January 16, 2024 04:26
@vercel Vercel
Copy link

vercel bot commented Jan 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 6:41am

@netlify Netlify
Copy link

netlify bot commented Jan 16, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 319e39b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65af5f86233d3c0008d60be0
😎 Deploy Preview https://deploy-preview-7041--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sriharsh05
Copy link
Contributor Author

@rithviknishad
Please review the PR.

rithviknishad
rithviknishad requested changes Jan 18, 2024
View reviewed changes
src/Redux/actions.tsx Outdated Show resolved Hide resolved
rithviknishad
rithviknishad requested changes Jan 18, 2024
View reviewed changes
src/Components/Facility/InventoryList.tsx Outdated Show resolved Hide resolved
src/Components/Facility/InventoryLog.tsx Outdated Show resolved Hide resolved
src/Components/Facility/InventoryLog.tsx Outdated Show resolved Hide resolved
src/Components/Facility/InventoryLog.tsx Outdated Show resolved Hide resolved
src/Redux/api.tsx Show resolved Hide resolved
@sriharsh05 sriharsh05 changed the title Replaced useDispatch with useQuery/request in Inventory list and Inventory Log. Replaced useDispatch with useQuery/request in Inventory Management Jan 19, 2024
@sriharsh05
Copy link
Contributor Author

@rithviknishad
Please review the changes.

@rithviknishad rithviknishad mentioned this pull request Jan 21, 2024
Closed
6 tasks
rithviknishad
rithviknishad requested changes Jan 21, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor improvements

src/Redux/api.tsx Outdated Show resolved Hide resolved
src/Redux/api.tsx Outdated Show resolved Hide resolved
src/Components/Facility/SetInventoryForm.tsx Outdated Show resolved Hide resolved
src/Components/Facility/SetInventoryForm.tsx Outdated Show resolved Hide resolved
src/Components/Facility/SetInventoryForm.tsx Outdated Show resolved Hide resolved
@rithviknishad
Copy link
Member

@sriharsh05 cypress tests are failing

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 9d2f678 into coronasafe:develop Jan 31, 2024
35 of 36 checks passed
@github-actions GitHub Actions
Copy link

@sriharsh05 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sriharsh05 @rithviknishad @nihal467 @Ashesh3 @khavinshankar