Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced useDispatch with useQuery/request in MinimumQuantityList, MinimumQuantityRequiredModal and SetInventoryForm. #7055

Closed
wants to merge 5 commits into from

Conversation

sriharsh05
Copy link
Contributor

@sriharsh05 sriharsh05 commented Jan 18, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sriharsh05 sriharsh05 requested a review from a team as a code owner January 18, 2024 13:31
Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4166d79
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65aa45714bc988000881bea1
😎 Deploy Preview https://deploy-preview-7055--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 9:49am

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sriharsh05 it'd be best to merge both the inventory management related PR's.

It'd be easier to do E2E test of inventory management module in one go, and you would also be able to delete shared references if combined.

@rithviknishad
Copy link
Member

Closing as completed in #7041

@sriharsh05 sriharsh05 deleted the fix#7036-2 branch January 23, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants