Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occupation dropdown frontend #7541

Merged
merged 13 commits into from
Apr 24, 2024
Merged

Conversation

hrit2773
Copy link
Contributor

@hrit2773 hrit2773 commented Apr 4, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@hrit2773 hrit2773 requested a review from a team as a code owner April 4, 2024 18:14
Copy link

vercel bot commented Apr 4, 2024

@hrit2773 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d2ef2dd
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6627bb2d0701e900088c8db6
😎 Deploy Preview https://deploy-preview-7541--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Components/Form/FormFields/Autocomplete.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientRegister.tsx Outdated Show resolved Hide resolved
hrit2773 and others added 2 commits April 5, 2024 10:31
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@hrit2773
Copy link
Contributor Author

hrit2773 commented Apr 5, 2024

@rithviknishad yes yes I didn't notice that it was already exported...

@hrit2773
Copy link
Contributor Author

hrit2773 commented Apr 5, 2024

@rithviknishad I made the backend PR also check the link in the issues

@rithviknishad
Copy link
Member

@nihal467
Copy link
Member

nihal467 commented Apr 8, 2024

@hrit2773 we are having a cypress test failure, fix it

Navigate to the "patient_spec" folder, then locate the "patient_registration.cy.ts" file. In this file, update the Occupation selection component. Currently, it uses "cy.clickAndSelectOption". Change this to reuse the "cy.searchAndSelectOption" function as you change the occupation component from a select form field to an autocomplete form field.

@nihal467 nihal467 added test failed cypress failed pull request with cypress test failure and removed needs testing needs review labels Apr 8, 2024
@hrit2773
Copy link
Contributor Author

coronasafe/care#2055 (review) @rithviknishad @sainak can you review the backend PR also

@nihal467 nihal467 added changes required and removed needs testing test failed cypress failed pull request with cypress test failure labels Apr 16, 2024
@nihal467
Copy link
Member

backend migration is failing

@rithviknishad
Copy link
Member

@nihal467 the migration seems to be passing. Could you show the logs?

@hrit2773
Copy link
Contributor Author

@rithviknishad maybe due to conflicting migrations after updating the branch the dependencies changed that's why maybe there was an issue anyways I deleted and re ran the migrations and pushed the code and that's why it seems to be passing. @nihal467 can you check again

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 66e5ff4 into coronasafe:develop Apr 24, 2024
27 of 29 checks passed
Copy link

@hrit2773 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the Patient registration page: Occupation dropdown is not suffecient.
4 participants