Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing slashes to api routes to avoid 301 responses from care #7663

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Apr 19, 2024

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner April 19, 2024 14:10
Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 2:11pm

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 56627e6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66227b68a2828b000832df35
😎 Deploy Preview https://deploy-preview-7663--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Apr 19, 2024

Passing run #2393 ↗︎

0 119 0 0 Flakiness 0

Details:

Add trailing slashes to api routes to avoid 301 responses from care
Project: CARE Commit: 56627e6945
Status: Passed Duration: 03:01 💡
Started: Apr 19, 2024 2:15 PM Ended: Apr 19, 2024 2:18 PM

Review all test suite changes for PR #7663 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 4e1e43c into develop Apr 24, 2024
60 of 61 checks passed
@khavinshankar khavinshankar deleted the sainak/fix/add-trailing-slash-to-api-routes branch April 24, 2024 06:42
Copy link

@sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants