Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes alignment of "Year of Birth" text in patient registration form #7694

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fixes alignment of "Year of Birth" text in patient registration form #7694

merged 2 commits into from
Apr 24, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner April 23, 2024 16:20
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 0:00am

@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8d9ea63
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6628f42f9a1b5100089a6f32
😎 Deploy Preview https://deploy-preview-7694--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad requested review from khavinshankar and removed request for sainak April 23, 2024 16:21
@cypress Cypress
Copy link

cypress bot commented Apr 23, 2024 •
edited

Passing run #2425 ↗︎

0 122 0 0 Flakiness 0

Details:

Fixes alignment of "Year of Birth" text in patient registration form
Project: CARE Commit: 8d9ea63f7d
Status: Passed Duration: 03:02 💡
Started: Apr 24, 2024 12:06 PM Ended: Apr 24, 2024 12:09 PM

Review all test suite changes for PR #7694 ↗︎

@Ashesh3
Copy link
Member

Ashesh3 commented Apr 24, 2024

Cypress tests failing

@nihal467
Copy link
Member

image

  • when i select age, and type 23 , the element go out of focus after 2 in the form

@nihal467 nihal467 added the P1 breaking issue or vital feature label Apr 24, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 218092b into develop Apr 24, 2024
58 of 60 checks passed
@khavinshankar khavinshankar deleted the issues/7692/fix-yob-alignment branch April 24, 2024 13:43
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"year of birth" text misaligned in patient registration form
4 participants
@rithviknishad @Ashesh3 @nihal467 @khavinshankar