Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade storybook to v8 #7741

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Apr 30, 2024

Proposed Changes

  • Fixes #issue_number
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner April 30, 2024 07:42
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 10:54am

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 72789dc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/663b597bd59c9f000812b937
😎 Deploy Preview https://deploy-preview-7741--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Apr 30, 2024

Passing run #2486 ↗︎

0 123 0 0 Flakiness 0

Details:

upgrade storybook to v8
Project: CARE Commit: 72789dc014
Status: Passed Duration: 04:21 💡
Started: May 8, 2024 10:59 AM Ended: May 8, 2024 11:04 AM

Review all test suite changes for PR #7741 ↗︎

@khavinshankar
Copy link
Member

@sainak build-storybook is failing

image

@sainak sainak marked this pull request as ready for review May 8, 2024 10:52
@nihal467
Copy link
Member

nihal467 commented May 8, 2024

@khavinshankar / @rithviknishad review it, marking it tested and need for review as deploys are passing

@khavinshankar khavinshankar merged commit 3025c46 into develop May 8, 2024
62 checks passed
@khavinshankar khavinshankar deleted the sainak/feat/update-storybook branch May 8, 2024 11:52
Copy link

github-actions bot commented May 8, 2024

@sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants