Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strings to env file #115

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Added strings to env file #115

merged 4 commits into from
Mar 20, 2023

Conversation

skks1212
Copy link
Member

  • Converted all customizable strings to env variables

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
leaderboard ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 11:04AM (UTC)

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation for the keys

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish
Copy link
Member

bodhish commented Mar 20, 2023

@skks1212 you may have to move documentation for the env file into readme. 😅

@bodhish
Copy link
Member

bodhish commented Mar 20, 2023

The quotes look odd 🧐
IMG_7739

@skks1212
Copy link
Member Author

@bodhish yep, fixing that!

@skks1212
Copy link
Member Author

@bodhish fixed, looks like Vercel has a strict .env parser 😬. Shifting documentation to readme...

@gigincg gigincg merged commit 1f949a1 into coronasafe:main Mar 20, 2023
sainak pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants