Migrate to NextJS 13 App Router + Typescript support #124
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
9f30dce
|
| Status: | 🚫 Build failed. |
| --dark-background: #111827; | ||
| --light-foreground: #020202; | ||
| --dark-foreground: #f9fafb; | ||
| } |
There was a problem hiding this comment.
I would have used the primary & secondary instead of background and foreground; Do we really need a primary + background + foreground ?
There was a problem hiding this comment.
So like, we would simply invert primary with secondary and vice-versa for dark mode and light mode?
There was a problem hiding this comment.
But primary and foreground colors are different right? We can't have primary color for all texts.
There was a problem hiding this comment.
Change primary and secondary for light and dark;
|
@rithviknishad lets clean up |
There was a problem hiding this comment.
@rithviknishad can you run prettier on all files once, use the config from care_fe.
update package-lock as well
|
We are currently having package-lock and yarn lock both checked-in. Shifting to |
componentsto typescriptlibto typescript