Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change cron time to every 12 hours #58

Merged
merged 3 commits into from
Jun 19, 2022
Merged

Conversation

kunatastic
Copy link
Contributor

fixes #57

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
leaderboard ✅ Ready (Inspect) Visit Preview Jun 19, 2022 at 3:26AM (UTC)

@bodhish
Copy link
Member

bodhish commented Jun 18, 2022

Can we run it twice a day?

@kunatastic
Copy link
Contributor Author

kunatastic commented Jun 19, 2022

Yeah!! we can do that that would be even better

@kunatastic kunatastic changed the title change cron time to 7:00PM IST change cron time to every 12 hours Jun 19, 2022
@kunatastic kunatastic requested a review from bodhish June 19, 2022 05:31
@bodhish bodhish merged commit 73ed558 into coronasafe:main Jun 19, 2022
@kunatastic kunatastic deleted the fix#57 branch June 19, 2022 17:35
@rithviknishad
Copy link
Member

@bodhish @kunatastic since its running every 12 hours, the workflow is appending data of past 24 hours every 12 hours, which causes the duplicates issue #63

@bodhish
Copy link
Member

bodhish commented Jun 28, 2022

I thought the data loading service handled it. We should fix it.

@rithviknishad
Copy link
Member

@bodhi nope, the scrapper seems to simply be using start and end date with no time specified. I'll try to fix it ASAP, but need to discuss abt how to remove duplicates in already generated data in today's EOD.

sainak pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing cron time to 7:00 PM
3 participants