Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI enhancements for search, sort and toggle #74

Merged
merged 3 commits into from
Sep 27, 2022
Merged

UI enhancements for search, sort and toggle #74

merged 3 commits into from
Sep 27, 2022

Conversation

naman114
Copy link
Contributor

Closes #73

The following changes were made:

  • Excess spacing between the search bar and live leaderboard is reduced

image

  • Search sort and toggle are placed in a single row in desktop and left justified in mobile view

image

@vercel
Copy link

vercel bot commented Aug 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
leaderboard ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 6:07PM (UTC)

@naman114 naman114 changed the title UI enhacements for search, sort and toggle UI enhancements for search, sort and toggle Aug 29, 2022
rabilrbl
rabilrbl suggested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@rabilrbl rabilrbl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The eye button still looks a bit off.
    image

@gigincg
Copy link
Member

gigincg commented Sep 2, 2022

@naman114 Can you take care of the changes @rabilrbl requested

@naman114
Copy link
Contributor Author

naman114 commented Sep 2, 2022

@rabilrbl @gigincg I am not able to replicate the issue on the deploy preview

@rabilrbl
Copy link
Contributor

rabilrbl commented Sep 2, 2022

@naman114 Its firefox related. It looks good on chromium.

@naman114
Copy link
Contributor Author

naman114 commented Sep 2, 2022

@gigincg @rabilrbl This is weird. What's the cause for this? Can we do anything?

@rabilrbl
Copy link
Contributor

rabilrbl commented Sep 2, 2022

@naman114 Fix naman114#2

rabilrbl
rabilrbl approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@rabilrbl rabilrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bodhish
bodhish approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish bodhish merged commit a435d56 into coronasafe:main Sep 27, 2022
sainak pushed a commit that referenced this pull request Dec 12, 2023
@bodhish
Merge pull request #74 from naman114/fix#73
df5376c 
UI enhancements for search, sort and toggle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish bodhish approved these changes

@rabilrbl rabilrbl rabilrbl approved these changes

@khavinshankar khavinshankar Awaiting requested review from khavinshankar

Assignees

@naman114 naman114

Labels
good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Enhancement for Search, Sort and Toggle
4 participants
@naman114 @gigincg @rabilrbl @bodhish