-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configured Typescript compiler (C4gt) #74
Conversation
configured typescript compiler
Good work @Amanshenoy008, there is one change needed, we prefer npm for package management, the yarn.lock was accidentally added to the repo which will be removed, can you also revert the changes done to yarn.lock and update package-lock.json instead |
yup , deleted yarn.lock . @sainak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build works fine, but the npm scripts are not updated, so it requires compiling to js manually, this should be updated along with proper nodemon config, now that the js files are generated in dist folder the dockerfile should be updated as well.
@sainak So, I updated the npm scripts and for dockers file should I change the workdir to /usr/dist/app |
fixed several inconsistencies
@Amanshenoy008 LGTM, can you resolve the conflicts |
@Amanshenoy008 resolve the merge conflicts |
Closing this pr wrt to #109 |
Proposed Changes:
part of :- ohcnetwork/care_fe#5495