Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured Typescript compiler (C4gt) #74

Closed
wants to merge 7 commits into from

Conversation

Amanshenoy008
Copy link

@Amanshenoy008 Amanshenoy008 commented Jul 5, 2023

Proposed Changes:

  • Configured the typescript compiler
  • Changed the file extenstion from .js to .ts

part of :- ohcnetwork/care_fe#5495

configured typescript compiler
@sainak
Copy link
Member

sainak commented Jul 6, 2023

Good work @Amanshenoy008, there is one change needed, we prefer npm for package management, the yarn.lock was accidentally added to the repo which will be removed, can you also revert the changes done to yarn.lock and update package-lock.json instead

@Amanshenoy008
Copy link
Author

Amanshenoy008 commented Jul 7, 2023

yup , deleted yarn.lock . @sainak

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build works fine, but the npm scripts are not updated, so it requires compiling to js manually, this should be updated along with proper nodemon config, now that the js files are generated in dist folder the dockerfile should be updated as well.

@Amanshenoy008
Copy link
Author

@sainak So, I updated the npm scripts and for dockers file should I change the workdir to /usr/dist/app

@sainak
Copy link
Member

sainak commented Sep 4, 2023

@Amanshenoy008 LGTM, can you resolve the conflicts

@khavinshankar khavinshankar self-assigned this Oct 16, 2023
@khavinshankar
Copy link
Member

@Amanshenoy008 resolve the merge conflicts

@khavinshankar
Copy link
Member

Closing this pr wrt to #109

cc: @Amanshenoy008 @sainak @gigincg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants