Switch cargo build working directory to the Manifest (cargo.toml) directory
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Aug 29, 2022
|
The CI is failing though (when Corrosion is used as a library) |
The output directory (target-dir) is left unchanged. Changing the cwd to the directory of the Manifest, has the advantage that cargo can pick up `.cargo/config.toml` files in the source tree. In the future this would also allow corrosion to respect `rust-toolchain.toml` and other rustup toolchain overrides. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
src-config-toml
branch
from
240d048
to
079d1f0
Compare
Fixed. The test requires Cargo >= 1.56, since that is when support for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output directory (target-dir) is left unchanged.
Changing the cwd to the directory of the Manifest, has the advantage that
cargo can pick up
.cargo/config.tomlfiles in the source tree.In the future this would also allow corrosion to respect
rust-toolchain.tomland other rustup toolchain overrides.
Closes #150