Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ninja Multi-Config Cross-Config support #492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Ninja Multi-Config Cross-Config support #492

wants to merge 3 commits into from

Commits on Apr 26, 2024

  1. Fix Ninja Multi-Config Cross-Config support 

    The default output directory was the same for all `$<CONFIG>`s,
which caused conflicting build rules.
The issue probably still exists for the rare case when:
1. The user specified an `OUTPUT_DIRECTORY` property AND
2. did not specify an `OUTPUT_DIRECTORY_$<CONFIG>` property AND
3. The value of the `OUTPUT_DIRECTORY` does not contain a genex,
  depending on the `$<CONFIG>`.

Corrosion could detect and append a `$<CONFIG>` in this case, but
I think leaving this up to the user is reasonable for now.
    @jschwe
    jschwe committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ffd53c5 View commit details
    Browse the repository at this point in the history

  2. Add Ninja Multi-Config Cross-Config test 

    Add a test with CMAKE_CROSS_CONFIGS set
    @jschwe
    jschwe committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fe023cf View commit details
    Browse the repository at this point in the history

  3. bump cmake version for ninja MC test

    @jschwe
    jschwe committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    85a0bd0 View commit details
    Browse the repository at this point in the history