Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix default value for inplace argument in RasterArray.set_nodata #509

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

apiwat-chantawibul
Copy link
Contributor

@apiwat-chantawibul apiwat-chantawibul commented Apr 16, 2022

Docstring for default value of inplace argument to RasterArray.set_nodata is changed to match actual implemented value (True).

@snowman2 snowman2 changed the title resolves #508 DOC: Fix default value for inplace argument in RasterArray.set_nodata Apr 18, 2022
@snowman2
Copy link
Member

Thanks @apiwat-chantawibul 👍

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #509 (21f2765) into master (64cc094) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          13       13           
  Lines        1581     1581           
=======================================
  Hits         1515     1515           
  Misses         66       66           
Impacted Files Coverage Δ
rioxarray/raster_array.py 97.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64cc094...21f2765. Read the comment docs.

@snowman2 snowman2 merged commit 160c890 into corteva:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Default value for inplace argument of RasterArray.set_nodata is inconsistent with its docstring.
3 participants