BUG: Handle netCDF _Unsigned and load in all attributes #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
==========================================
+ Coverage 96.25% 96.30% +0.05%
==========================================
Files 13 13
Lines 1603 1652 +49
==========================================
+ Hits 1543 1591 +48
- Misses 60 61 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
snowman2
force-pushed
the
unsigned
branch
5 times, most recently
from
8b6e2cb
to
8b52bfe
Compare
snowman2
changed the title
justingruca
approved these changes
Sep 14, 2022
|
Thanks @justingruca 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/history.rstfor all changes anddocs/rioxarray.rstfor new APIUpdated unsigned logic based on:
https://github.com/pydata/xarray/blob/abe1e613a96b000ae603c53d135828df532b952e/xarray/coding/variables.py#L306-L334
This required updating loading attributes to ensure the
_Unsignedproperty is saved/loaded correctly.