Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add region field to input data #155

Merged
merged 4 commits into from
Jun 12, 2019
Merged

Add region field to input data #155

merged 4 commits into from
Jun 12, 2019

Conversation

vishalbollu
Copy link
Contributor

Resolves #115

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart local operator, and run cx refresh in an example folder)
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu June 11, 2019 12:28
deliahu
deliahu approved these changes Jun 11, 2019
View reviewed changes
pkg/lib/aws/s3.go Outdated Show resolved Hide resolved
pkg/lib/aws/s3.go Outdated Show resolved Hide resolved
pkg/operator/workloads/data_job.go Outdated Show resolved Hide resolved
@vishalbollu vishalbollu merged commit 9a51405 into master Jun 12, 2019
@deliahu deliahu deleted the add-region-data-path branch June 13, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support bucket regions for data ingestion
2 participants
@vishalbollu @deliahu