Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer evalutation in ruler configmap #242

Merged
merged 1 commit into from Oct 14, 2021

Conversation

Skaronator
Copy link
Contributor

What this PR does: This fixes the nil pointer evaluation when using the directories option.

template: cortex/templates/ruler/ruler-configmap.yaml:8:24: executing "cortex/templates/ruler/ruler-configmap.yaml" at <.Release.Namespace>: nil pointer evaluating interface {}.Namespace

This change is required since we change the . scope with the range loop in line 2 of that file which means what . does no longer contain Releases and Namespace.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! LGTM

@nschad nschad requested a review from kd7lxl October 13, 2021 06:40
@nschad nschad closed this Oct 14, 2021
@nschad nschad reopened this Oct 14, 2021
@nschad
Copy link
Collaborator

nschad commented Oct 14, 2021

image
Argh I think its bugged, tried reopening but that didn't seem to work

Edit: Pushing an empty commit seemed to do the trick

Signed-off-by: Niklas Wagner <Skaro@Skaronator.com>
@nschad nschad merged commit 90e53a2 into cortexproject:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants