add dns discovery method for query-scheduler address #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nschad <niclas.schad@gmail.com>
nschad
force-pushed
the
fix-scheduler-addresses
branch
from
b5c447e
to
91f9a9f
Compare
nschad
commented
Mar 15, 2022
Comment on lines
-51
to
-56
| frontend: | ||
| scheduler_address: 'dns+{{ include "cortex.querySchedulerFullname" $ }}-headless:9095' | ||
|
|
||
| frontend_worker: | ||
| scheduler_address: 'dns+{{ include "cortex.querySchedulerFullname" $ }}-headless:9095' | ||
|
|
There was a problem hiding this comment.
Was already set via cli @kd7lxl . CLI args should take precedence over the config file also, therefore safe to remove
Signed-off-by: nschad <niclas.schad@gmail.com>
Signed-off-by: nschad <niclas.schad@gmail.com>
kd7lxl
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nschad niclas.schad@gmail.com
What this PR does:
Improve/Fix query-scheduler addresses
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]