Correctly interpret .Capabilities.KubeVersion when it looks like a prerelease #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschad
approved these changes
May 5, 2023
…erelease Signed-off-by: Tom Hayward <thayward@infoblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The chart uses
semverCompareto interpret.Capabilties.KubeVersion.semverCompareby default will ignore prereleases. A Kubernetes prerelease will still support the newer API versions targeted for that release, so the chart should allow prereleases when doing version comparisons.Moreover, popular Kubernetes releases such as AWS EKS [improperly] use prerelease annotation in their version strings, like
1.25.8-eks-ec5523e, so this issue could cause incorrect API versions to be selected on those clusters.semverComparesupports allowing prereleases by adding-0to the operand, like>=1.21-0.This PR adds
-0to the version comparison so that versions that look like prereleases are supported.References:
Which issue(s) this PR fixes:
Fixes #160
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]