Skip to content

Commit

Permalink
Changed default value of -blocks-storage.bucket-store.sync-interval f…
Browse files Browse the repository at this point in the history
…rom 5m to 15m (#3724)

* Changed default value of -blocks-storage.bucket-store.sync-interval form 5m to 15m

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Updated CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>
  • Loading branch information
pracucci committed Jan 21, 2021
1 parent 0e26caf commit fdc1bb2
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -21,6 +21,7 @@
* `-cluster.advertise-address` in favor of `-alertmanager.cluster.advertise-address`
* `-cluster.peer` in favor of `-alertmanager.cluster.peers`
* `-cluster.peer-timeout` in favor of `-alertmanager.cluster.peer-timeout`
* [CHANGE] Blocks storage: the default value of `-blocks-storage.bucket-store.sync-interval` has been changed from `5m` to `15m`. #3724
* [FEATURE] Querier: Queries can be federated across multiple tenants. The tenants IDs involved need to be specified separated by a `|` character in the `X-Scope-OrgID` request header. This is an experimental feature, which can be enabled by setting `-tenant-federation.enabled=true` on all Cortex services. #3250
* [FEATURE] Alertmanager: introduced the experimental option `-alertmanager.sharding-enabled` to shard tenants across multiple Alertmanager instances. This feature is still under heavy development and its usage is discouraged. The following new metrics are exported by the Alertmanager: #3664
* `cortex_alertmanager_ring_check_errors_total`
Expand Down
2 changes: 1 addition & 1 deletion docs/blocks-storage/querier.md
Expand Up @@ -387,7 +387,7 @@ blocks_storage:
# enabled), in order to look for changes (new blocks shipped by ingesters
# and blocks deleted by retention or compaction).
# CLI flag: -blocks-storage.bucket-store.sync-interval
[sync_interval: <duration> | default = 5m]
[sync_interval: <duration> | default = 15m]

# Max size - in bytes - of a per-tenant chunk pool, used to reduce memory
# allocations.
Expand Down
2 changes: 1 addition & 1 deletion docs/blocks-storage/store-gateway.md
Expand Up @@ -434,7 +434,7 @@ blocks_storage:
# enabled), in order to look for changes (new blocks shipped by ingesters
# and blocks deleted by retention or compaction).
# CLI flag: -blocks-storage.bucket-store.sync-interval
[sync_interval: <duration> | default = 5m]
[sync_interval: <duration> | default = 15m]

# Max size - in bytes - of a per-tenant chunk pool, used to reduce memory
# allocations.
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration/config-file-reference.md
Expand Up @@ -3799,7 +3799,7 @@ bucket_store:
# enabled), in order to look for changes (new blocks shipped by ingesters and
# blocks deleted by retention or compaction).
# CLI flag: -blocks-storage.bucket-store.sync-interval
[sync_interval: <duration> | default = 5m]
[sync_interval: <duration> | default = 15m]

# Max size - in bytes - of a per-tenant chunk pool, used to reduce memory
# allocations.
Expand Down
2 changes: 1 addition & 1 deletion pkg/storage/tsdb/config.go
Expand Up @@ -243,7 +243,7 @@ func (cfg *BucketStoreConfig) RegisterFlags(f *flag.FlagSet) {
cfg.BucketIndex.RegisterFlagsWithPrefix(f, "blocks-storage.bucket-store.bucket-index.")

f.StringVar(&cfg.SyncDir, "blocks-storage.bucket-store.sync-dir", "tsdb-sync", "Directory to store synchronized TSDB index headers.")
f.DurationVar(&cfg.SyncInterval, "blocks-storage.bucket-store.sync-interval", 5*time.Minute, "How frequently to scan the bucket, or to refresh the bucket index (if enabled), in order to look for changes (new blocks shipped by ingesters and blocks deleted by retention or compaction).")
f.DurationVar(&cfg.SyncInterval, "blocks-storage.bucket-store.sync-interval", 15*time.Minute, "How frequently to scan the bucket, or to refresh the bucket index (if enabled), in order to look for changes (new blocks shipped by ingesters and blocks deleted by retention or compaction).")
f.Uint64Var(&cfg.MaxChunkPoolBytes, "blocks-storage.bucket-store.max-chunk-pool-bytes", uint64(2*units.Gibibyte), "Max size - in bytes - of a per-tenant chunk pool, used to reduce memory allocations.")
f.IntVar(&cfg.MaxConcurrent, "blocks-storage.bucket-store.max-concurrent", 100, "Max number of concurrent queries to execute against the long-term storage. The limit is shared across all tenants.")
f.IntVar(&cfg.TenantSyncConcurrency, "blocks-storage.bucket-store.tenant-sync-concurrency", 10, "Maximum number of concurrent tenants synching blocks.")
Expand Down

0 comments on commit fdc1bb2

Please sign in to comment.