Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors in querier: []promql.Point: unsupported value: NaN #1668

Closed
bboreham opened this issue Sep 16, 2019 · 2 comments · Fixed by #1675
Closed

errors in querier: []promql.Point: unsupported value: NaN #1668

bboreham opened this issue Sep 16, 2019 · 2 comments · Fixed by #1675
Labels
type/bug

Comments

@bboreham
Copy link
Contributor 

level=error ts=2019-09-16T12:39:17.30841883Z caller=api.go:1110 msg="error marshaling json response" err="v1.response.Data: v1.queryData.Result: promql.Matrix: promql.Series.Points: []promql.Point: unsupported value: NaN"

Not sure what causes it but myself and a user on Slack have both encountered this message.
@bboreham
Copy link
Contributor Author

The Slack message led to prometheus/client_golang#570, where code was added to marshalPointJSON() to allow NaN, but no similar code was added to prometheus/prometheus/web/api/v1/api.go .

When jsoniter is updated to a version that de-supports NaN, as was done in #1597, we get this error.

@gouthamve
Copy link
Contributor

Fixed in prometheus/prometheus#6030 Will vendor in after that is merged.

@gouthamve gouthamve mentioned this issue Sep 18, 2019
Merged
gouthamve added a commit to gouthamve/cortex that referenced this issue Sep 18, 2019
@gouthamve
vendor: Update prometheus/prometheus
7fa51e0 
Fixes: cortexproject#1668

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve added a commit that referenced this issue Sep 19, 2019
@gouthamve
vendor: update prometheus/prometheus to latest. (#1675)
5e61a35 
* vendor: Update prometheus/prometheus

Fixes: #1668

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* Match new signature

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vendor: update prometheus/prometheus to latest. gouthamve/cortex
2 participants
@gouthamve @bboreham